2018-01-17 23:07 GMT+01:00 Brian Norris <briannorris@xxxxxxxxxxxx>: > + Enric > > On Fri, Jan 12, 2018 at 06:08:22PM +0800, William Wu wrote: >> This patch adds USB3 OTG reset property for rk3399 Type-C PHY >> to hold the USB3 controller in reset state. >> >> Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx> >> --- > > I was going back and forth on this, since at one point this binding was > merged but had no enabled users...but now I see Heiko has queued up some > of Enric's work for 4.16, and it uses the existing binding. > > So, if this reset is added, it should be optional. > As Brian said commit 06c47e6286d5 'usb: dwc3: of-simple: Add support to get resets for the device' introduced the support to get the resets from dwc3-of-simple and the queued commit 'b7e63d95c14d arm64: dts: rockchip: add reset property for dwc3 controllers on rk3399' started using it. Without the latest I get errors like this doing bind/unbind tests. dwc3: probe of fe900000.dwc3 failed with error -110 I just tested these series on top of mainline, I reverted my patch because otherwise two drivers are requesting the same reset and fails, and I did some of the bind/unbind test. They just worked fine, and seems that this is right way, so this makes me think some questions. Should 'b7e63d95c14d arm64: dts: rockchip: add reset property for dwc3 controllers on rk3399' removed for 4.16? That's a question for Heiko I guess, if it's removed we will have usb broken meanwhile these patches doesn't land. If we don't remove the patch we will need to introduce a new patch in this series that reverts the first patch. Is commit 06c47e6286d5 'usb: dwc3: of-simple: Add support to get resets for the device' really needed ? Seems that I was the only user of it. Anyway, these patches looks good to me and are Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > Brian > >> Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt >> index 6ea867e..db2902e 100644 >> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt >> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt >> @@ -13,7 +13,7 @@ Required properties: >> - assigned-clock-rates : the phy core clk frequency, shall be: 50000000 >> - resets : a list of phandle + reset specifier pairs >> - reset-names : string reset name, must be: >> - "uphy", "uphy-pipe", "uphy-tcphy" >> + "uphy", "uphy-pipe", "uphy-tcphy", "usb3-otg" >> - extcon : extcon specifier for the Power Delivery >> >> Note, there are 2 type-c phys for RK3399, and they are almost identical, except >> @@ -56,8 +56,9 @@ Example: >> assigned-clock-rates = <50000000>; >> resets = <&cru SRST_UPHY0>, >> <&cru SRST_UPHY0_PIPE_L00>, >> - <&cru SRST_P_UPHY0_TCPHY>; >> - reset-names = "uphy", "uphy-pipe", "uphy-tcphy"; >> + <&cru SRST_P_UPHY0_TCPHY>, >> + <&cru SRST_A_USB3_OTG0>; >> + reset-names = "uphy", "uphy-pipe", "uphy-tcphy", "usb3-otg"; >> rockchip,typec-conn-dir = <0xe580 0 16>; >> rockchip,usb3tousb2-en = <0xe580 3 19>; >> rockchip,external-psm = <0xe588 14 30>; >> @@ -84,8 +85,9 @@ Example: >> assigned-clock-rates = <50000000>; >> resets = <&cru SRST_UPHY1>, >> <&cru SRST_UPHY1_PIPE_L00>, >> - <&cru SRST_P_UPHY1_TCPHY>; >> - reset-names = "uphy", "uphy-pipe", "uphy-tcphy"; >> + <&cru SRST_P_UPHY1_TCPHY>, >> + <&cru SRST_A_USB3_OTG1>; >> + reset-names = "uphy", "uphy-pipe", "uphy-tcphy", "usb3-otg"; >> rockchip,typec-conn-dir = <0xe58c 0 16>; >> rockchip,usb3tousb2-en = <0xe58c 3 19>; >> rockchip,external-psm = <0xe594 14 30>; >> -- >> 2.0.0 >> >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
