On Thu, Jan 18, 2018 at 06:20:09PM +0100, Enric Balletbo Serra wrote: > As Brian said commit 06c47e6286d5 'usb: dwc3: of-simple: Add support > to get resets for the device' introduced the support to get the resets > from dwc3-of-simple and the queued commit 'b7e63d95c14d arm64: dts: > rockchip: add reset property for dwc3 controllers on rk3399' started > using it. Without the latest I get errors like this doing bind/unbind > tests. > > dwc3: probe of fe900000.dwc3 failed with error -110 > > I just tested these series on top of mainline, I reverted my patch > because otherwise two drivers are requesting the same reset and fails, > and I did some of the bind/unbind test. They just worked fine, and > seems that this is right way, so this makes me think some questions. Actually, this was intended to coexist with DWC3 optionally controlling the same reset. It was written before the reset framework was rewritten to have shared and exclusive resets. Should this be rewritten to use shared resets? We'd have to modify both dwc3 core and the PHY driver. > Should 'b7e63d95c14d arm64: dts: rockchip: add reset property for dwc3 > controllers on rk3399' removed for 4.16? That's a question for Heiko I > guess, if it's removed we will have usb broken meanwhile these patches > doesn't land. If we don't remove the patch we will need to introduce a > new patch in this series that reverts the first patch. If we don't make this shared, I suppose Rockchip should rewrite this series and rebase on Heiko's tree, where the DTSI change should just remove the reset from DWC3 and add it to the PHY node at the same time. That would be an atomic, non-breaking change. > Is commit 06c47e6286d5 'usb: dwc3: of-simple: Add support to get > resets for the device' really needed ? Seems that I was the only user > of it. I don't personally know the history of this one. I just noticed that you started using it to resolve a problem that was implemented differently in our downstream tree. > Anyway, these patches looks good to me and are > > Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> Awesome. Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
