On Fri, Dec 15, 2017 at 10:08:52AM -0800, Tony Lindgren wrote: > The ti-sysc binding does not yet describe the capabilities of the > interconnect target module. So to make the ti-sysc binding usable > for configuring the interconnect target module, we need to add few > more properties: > > 1. To detect between omap2 and omap4 timers, let's add compatibles > for them for "ti,sysc-omap2-timer" and,sysc-omap4-timer". This > makes it easier to pick up the already initialized system timers > later on > > 2. Let's add "ti,sysc-mask" for a mask of features supported by the > interconnect target module. This describes what we have available > in the various SYSCONFIG registers > > 3. Let's add "ti,sysc-midle" and "ti,sysc-sidle" lists for the master > and slave idle modes supported by the interconnect target module. > These describe the values available for MIDLE and SIDLE bits in > the SYSCONFIG registers > > 4. Some interconnect target modules need a short delay after reset > before they can be accessed, let's use "ti,sysc-delay-us" for > that > > 5. Let's add "ti,syss-mask" bit to describe the optional SYSSTATUS > register bits for reset done bits > > 6. Let's support the two existing custom quirk properties already > listed in Documentation/devicetree/bindings/arm/omap/omap.txt for > "ti,no-reset-on-init" and "ti,no-idle-on-init" > > 7. And finally, let's add a header for the binding for the dts > files and the driver to use > > Cc: Benoît Cousson <bcousson@xxxxxxxxxxxx> > Cc: Dave Gerlach <d-gerlach@xxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx> > Cc: Mark Brown <broonie@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > Cc: Matthijs van Duin <matthijsvanduin@xxxxxxxxx> > Cc: Paul Walmsley <paul@xxxxxxxxx> > Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxx> > Cc: Suman Anna <s-anna@xxxxxx> > Cc: Tero Kristo <t-kristo@xxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/bus/ti-sysc.txt | 36 +++++++++++++++++++++++ > include/dt-bindings/bus/ti-sysc.h | 22 ++++++++++++++ > 2 files changed, 58 insertions(+) > create mode 100644 include/dt-bindings/bus/ti-sysc.h > > diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt b/Documentation/devicetree/bindings/bus/ti-sysc.txt > --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt > +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt > @@ -26,6 +26,8 @@ Required standard properties: > or one of the following derivative types for hardware > needing special workarounds: > > + "ti,sysc-omap2-timer" > + "ti,sysc-omap4-timer" > "ti,sysc-omap3430-sr" > "ti,sysc-omap3630-sr" > "ti,sysc-omap4-sr" > @@ -49,6 +51,26 @@ Required standard properties: > > Optional properties: > > +- ti,sysc-mask shall contain mask of supported register bits for the > + SYSCONFIG register as documented in the Technical Reference > + Manual (TRM) for the interconnect target module > + > +- ti,sysc-midle list of master idle modes supported by the interconnect > + target module as documented in the TRM for SYSCONFIG > + register MIDLEMODE bits > + > +- ti,sysc-sidle list of slave idle modes supported by the interconnect > + target module as documented in the TRM for SYSCONFIG > + register SIDLEMODE bits > + > +- ti,sysc-delay-us delay needed after OCP softreset before accssing > + SYSCONFIG register again > + > +- ti,syss-mask optional mask of reset done status bits as described in the > + TRM for SYSSTATUS registers, typically 1 with some devices > + having separate reset done bits for children like OHCI and > + EHCI > + Seems like a lot of this should be implied by specific compatible strings. Are the bits you've defined all of them or there's more? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
