> > > > +static struct i2c_driver bcm59056_i2c_driver = { > > > > + .driver = { > > > > + .name = "bcm59056", > > > > + .owner = THIS_MODULE, > > > > + .of_match_table = of_match_ptr(bcm59056_of_match), > > > > No need to use of_match_ptr() here. > > > Will remove. > > What using of_match_ptr() should do is allow the compiler to figure out > that the table isn't used when DT is disabled and discard it without > ifdefs. Not sure if that actually works yet but that's the idea. Right, but I'm guessing that as there is no support for platform data then this device(s) is going to be DT only? If that's the case perhaps a 'depends OF' might be in order. If that's not the case then I'm more than happy to leave the of_match_ptr() in. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html