Hi Masahiro. On Thu, Nov 09, 2017 at 02:53:04PM +0900, Masahiro Yamada wrote: > Hi Sam, > > Thanks for your review. > > 2017-11-09 14:35 GMT+09:00 Sam Ravnborg <sam@xxxxxxxxxxxx>: > > Hi Masahiro. > > > > Thanks for picking this up. > > > >> A key point is, the parent Makefile knows whether built-in.o is needed > >> or not. If a subdirectory needs to create built-in.o, its parent can > >> tell the fact when Kbuild descends into it. > > Good observation! > >> > >> diff --git a/Makefile b/Makefile > >> index 008a4e5..cc0b618 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -1003,7 +1003,7 @@ $(sort $(vmlinux-deps)): $(vmlinux-dirs) ; > >> > >> PHONY += $(vmlinux-dirs) > >> $(vmlinux-dirs): prepare scripts > >> - $(Q)$(MAKE) $(build)=$@ > >> + $(Q)$(MAKE) $(build)=$@ need-builtin=1 > > > > The need-bultin may also be required for the shortcuts > > that allows one to use: > > > > make <dir>/ > > > > example: > > > > make net/ > > > I do not want to add need-builtin=1 for single targets. > > > make scripts/ > would create false scripts/built-in.o > This is odd. > > I wrote the solution in the commit log: > $(obj-y) should be still checked to support the single target "%/". I missed this bit in the commit log, but I almost commented on this in the patch itself. Good way to do it. Sam -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
