On Thu, Nov 09, 2017 at 08:13:17AM -0600, Andrew F. Davis wrote: > On 11/09/2017 06:41 AM, Mark Brown wrote: > > There's other things in here like adding error reporting... please > > don't send changes like this, if you want to do cleanups you should > > split them up in the same way you would other changes. Bigger patches > > are harder to review especially if they're not repetitive examples of > > the same pattern. > I'm never really sure with these where the split point should be, almost > every change in here could be its own patch if I really wanted to pad my > kernel patch count, but this series is already 17 patches long and I > usually see these all as the same logical action: non-functional cleanups. > I agree the added error message isn't purely non-functional and so > should be broken out, I'll break out a couple other changes for v2. This is why cleanups don't happen :) A separate cleanup series would probably cover it, when they're split up well they're quick and easy to review.
Attachment:
signature.asc
Description: PGP signature
