On Wed, Oct 25, 2017 at 04:44:09PM +0800, Shawn Guo wrote: > +static int histb_combphy_init(struct phy *phy) > +{ > + struct histb_combphy_priv *priv = phy_get_drvdata(phy); > + u32 val; > + int ret; > + > + /* PHY0 doesn't support mode setting */ > + if (priv->phy_id != 0) { With a bit more think on this, I admit it might not scale for future SoCs which could reasonably support mode select for combphy0. So instead of hard checking device id, I will repost with a new property added for this. Shawn > + ret = histb_combphy_set_mode(priv); > + if (ret) > + return ret; > + } -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html