Re: [PATCH] phy-rcar-usb-gen2: add device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello.

On 29-01-2014 16:22, Simon Horman wrote:

[snip]

+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+    { .compatible = "renesas,usb-phy-r8a7790", },
+    { .compatible = "renesas,rcar-gen2-usb-phy", },

    Frankly speaking, I don't understand the need for the clearly
duplicate entries.

Thanks, will look into remove it.
Anyone else have any comments on this?

I would like you to leave it there.

As we know the r8a7790 is an R-Car Gen2 SoC.  But there are other R-Car
Gen2 SoCs, such as the r8a7791, they it could plausibly make use of
rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry.

    Why not just "update" the driver this way now, may I ask?

Because I don't believe that Ben has access to r8a7791 hardware
to test the change and thus it makes sense to handle it separately.

   I believe Valentine has already tested the driver with both SoCs.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux