On Mon, Jan 27, 2014 at 07:06:26PM +0000, Ben Dooks wrote: > On 27/01/14 18:23, Sergei Shtylyov wrote: > >Hello. > > > >On 01/26/2014 08:05 PM, Ben Dooks wrote: > > [snip] > > >> > >>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>+ { .compatible = "renesas,usb-phy-r8a7790", }, > >>+ { .compatible = "renesas,rcar-gen2-usb-phy", }, > > > > Frankly speaking, I don't understand the need for the clearly > >duplicate entries. > > Thanks, will look into remove it. > Anyone else have any comments on this? I would like you to leave it there. As we know the r8a7790 is an R-Car Gen2 SoC. But there are other R-Car Gen2 SoCs, such as the r8a7791, they it could plausibly make use of rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html