On Mon, Jan 27, 2014 at 01:27:09PM +0000, Ben Dooks wrote:
> On 27/01/14 12:48, Sergei Shtylyov wrote:
> >Hello.
> >
> >On 26-01-2014 20:48, Ben Dooks wrote:
> >
> >>Add OF match table for pci-rcar-gen2 driver for device tree support.
> >
> >>Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> >>---
> >>Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >>Cc: Simon Horman <horms@xxxxxxxxxxxx>
> >>Cc: linux-pci@xxxxxxxxxxxxxxx
> >>Cc: linux-sh@xxxxxxxxxxxxxxx
> >>Cc: devicetree@xxxxxxxxxxxxxxx
> >>---
> >> drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >
> >>diff --git a/drivers/pci/host/pci-rcar-gen2.c
> >>b/drivers/pci/host/pci-rcar-gen2.c
> >>index ceec147..ea65bac 100644
> >>--- a/drivers/pci/host/pci-rcar-gen2.c
> >>+++ b/drivers/pci/host/pci-rcar-gen2.c
> >>@@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct
> >>platform_device *pdev)
> >> return rcar_pci_add_controller(priv);
> >> }
> >>
> >>+static struct of_device_id rcar_pci_of_match[] = {
> >>+ { .compatible = "renesas,pci-r8a7790", },
> >
> > Why only H2 SoC, if the driver is for both Gen2 SoCs?
>
> I can add a "renesas,pci-rcar-gen2" as a fallback match however
> I've not got anything other than an r8a7790 to test on. Also the
> compatible properties are preferably named after the soc.
I'm not sure what the "best practice" is here but I propose that
you add both "renesas,pci-rcar-gen2" and "renesas,pci-r8a7790" now.
And that "renesas,pci-r8a7791" can be added once the code has been
integrated and tested on that platform.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
