Hi, Sascha Thanks for the reminder, will improve it in V2. Best Regards. Anson huang 黄勇才 Freescale Semiconductor Shanghai 上海浦东新区亮景路192号A座2楼 201203 Tel:021-28937058 >-----Original Message----- >From: Sascha Hauer [mailto:s.hauer@xxxxxxxxxxxxxx] >Sent: Monday, January 20, 2014 7:54 PM >To: Huang Yongcai-B20788 >Cc: shawn.guo@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx >Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: correct gpio key's active >state > >On Mon, Jan 20, 2014 at 07:42:33PM +0800, Anson Huang wrote: >> From schematic, the power, vol+/- key's active state is low, so we >> need to set the gpio flag to active low. >> >> Signed-off-by: Anson Huang <b20788@xxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi >> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi >> index 91e5dd4..f7689b4 100644 >> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi >> @@ -58,21 +58,21 @@ >> >> power { >> label = "Power Button"; >> - gpios = <&gpio3 29 0>; >> + gpios = <&gpio3 29 1>; > >When touching this you could take the opportunity and use GPIO_ACTIVE_LOW. > >Sascha > >-- >Pengutronix e.K. | | >Industrial Linux Solutions | http://www.pengutronix.de/ | >Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
