On Mon, May 22, 2017 at 04:00:47PM +0200, Quentin Schulz wrote: > Hi Andrew > > On 22/05/2017 15:57, Andrew Lunn wrote: > > On Mon, May 22, 2017 at 11:15:17AM +0200, Quentin Schulz wrote: > >> Some PHY require to wait for a bit after the reset GPIO has been > >> toggled. This adds support for the DT property `phy-reset-post-delay` > >> which gives the delay in milliseconds to wait after reset. > >> > >> If the DT property is not given, no delay is observed. Post reset delay > >> greater than 1000ms are invalid and are default to 1ms. > > > > Hi Quentin > > > > If it is invalid, please return -EINVAL. > > > > Just copying the wording and behavior of phy-reset-duration. Should we > then change the behavior of phy-reset-duration as well to return -EINVAL > in that case or I just leave both as is? No, you cannot change phy-reset-duration. There could be device tree blobs out in the wild with invalid phy-reset-duration which silently get converted to 1000ms by the code. You cannot break them. However, you can prevent new additions which add invalid phy-reset-post-delay. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html