On Mon, May 22, 2017 at 9:33 AM, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > Hi Rob, > > Thanks for the review! > > On 05/22/17 17:22, Rob Herring wrote: >> On Mon, May 22, 2017 at 3:11 AM, Sakari Ailus >> <sakari.ailus@xxxxxxxxxxxxxxx> wrote: >>> base.c contains both core OF functions and increasingly other >>> functionality such as accessing properties and graphs, including >>> convenience functions. In the near future this would also include OF >>> specific implementation of the fwnode property and graph APIs. >>> >>> Create driver/of/property.c to contain procedures for accessing and >>> interpreting device tree properties. The procedures are moved from >>> drivers/of/base.c, with no changes other than copying only the includes >>> required by the moved procedures. >>> >>> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >>> --- >>> drivers/of/Makefile | 2 +- >>> drivers/of/base.c | 733 ------------------------------------------------ >>> drivers/of/property.c | 763 ++++++++++++++++++++++++++++++++++++++++++++++++++ >> >> Please put graph functions in graph.c unless there is some reason not to. > > There will be a single fwnode ops struct which will contain both > property and graph API primitives. The functions implementing the > operations will be private, albeit the corresponding OF functions they > will use are global. > > If I split current properties.c, which of these should the fwnode ops > struct and the function callbacks be put? The patch is here (and the > previous one; both were submitted earlier today): Okay, makes sense. The filename is a bit confusing, but I don't have a better suggestion. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
