Hello, On Thu, Mar 30, 2017 at 08:30:29AM +0200, Stefan Wahren wrote: > > > Eduardo Valentin <edubezval@xxxxxxxxx> hat am 30. März 2017 um 06:57 geschrieben: > > > > > > On Tue, Mar 28, 2017 at 09:58:09PM -0700, Eduardo Valentin wrote: > > > On Sun, Mar 12, 2017 at 10:11:05PM +0000, Stefan Wahren wrote: > > > > Add basic thermal driver for bcm2835 SoC. > > > > > > > > This driver currently make sure that tsense HW block is set up > > > > correctly. > > > > > > > > Signed-off-by: Martin Sperl <kernel@xxxxxxxxxxxxxxxx> > > > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > > > > Acked-by: Eric Anholt <eric@xxxxxxxxxx> > > > > > > I see no issue with this driver at this point. > > > > > > As I mentioned, the full series needs to go together. You either get an > > > Ack from OF maintainers, and I take the series, or you can add my > > > > > > Acked-by: Eduardo Valentin <edubezval@xxxxxxxxx> > > > > > > after fixing the small comment from Nobuhiro. > > > > > > > Based on other drivers that require negative values, I assume patches 1 > > and 2 of these series are needed, but more for enforcing the API, given > > that the current of-thermal driver still retrieves the negative values > > from DTB [1]. > > > > [1] - https://patchwork.kernel.org/patch/9612613/ > > I can't see that the OMAP5 thermal driver is using thermal_zone_get_slope() [2]. I got the wrong values without patch 1 and 2. So i wouldn't rely on that statement. But i will doublecheck it. The TI-SoC driver is not currently using the slope and offset from DT. But on my -linus branch I have added three patches from Keerthy that adds that support. Anyways, I am assuming you are also getting correct values at your end, based on your other email. BR, > > [2] - http://elixir.free-electrons.com/ident?v=4.11-rc4&i=thermal_zone_get_slope -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
