On Tue, Mar 28, 2017 at 09:58:09PM -0700, Eduardo Valentin wrote: > On Sun, Mar 12, 2017 at 10:11:05PM +0000, Stefan Wahren wrote: > > Add basic thermal driver for bcm2835 SoC. > > > > This driver currently make sure that tsense HW block is set up > > correctly. > > > > Signed-off-by: Martin Sperl <kernel@xxxxxxxxxxxxxxxx> > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > > Acked-by: Eric Anholt <eric@xxxxxxxxxx> > > I see no issue with this driver at this point. > > As I mentioned, the full series needs to go together. You either get an > Ack from OF maintainers, and I take the series, or you can add my > > Acked-by: Eduardo Valentin <edubezval@xxxxxxxxx> > > after fixing the small comment from Nobuhiro. > Based on other drivers that require negative values, I assume patches 1 and 2 of these series are needed, but more for enforcing the API, given that the current of-thermal driver still retrieves the negative values from DTB [1]. A third option on top of what I suggested above is to split the series. Given that you could still get the proper coefficients with current of-thermal, I would suggest you to split this series into two (patches 1-2, 3-6) in your next version, so we avoid futher delays on the driver, while patches 1-2 waits for acks from OF side. [1] - https://patchwork.kernel.org/patch/9612613/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
