On Sun, Mar 12, 2017 at 10:11:05PM +0000, Stefan Wahren wrote: > Add basic thermal driver for bcm2835 SoC. > > This driver currently make sure that tsense HW block is set up > correctly. > > Signed-off-by: Martin Sperl <kernel@xxxxxxxxxxxxxxxx> > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > Acked-by: Eric Anholt <eric@xxxxxxxxxx> I see no issue with this driver at this point. As I mentioned, the full series needs to go together. You either get an Ack from OF maintainers, and I take the series, or you can add my Acked-by: Eduardo Valentin <edubezval@xxxxxxxxx> after fixing the small comment from Nobuhiro. > --- > drivers/thermal/Kconfig | 8 + > drivers/thermal/Makefile | 1 + > drivers/thermal/bcm2835_thermal.c | 315 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 324 insertions(+) > create mode 100644 drivers/thermal/bcm2835_thermal.c > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 776b343..3bd2406 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -453,4 +453,12 @@ config ZX2967_THERMAL > the primitive temperature sensor embedded in zx2967 SoCs. > This sensor generates the real time die temperature. > > +config BCM2835_THERMAL > + tristate "Thermal sensors on bcm2835 SoC" > + depends on ARCH_BCM2835 || COMPILE_TEST > + depends on HAS_IOMEM > + depends on THERMAL_OF > + help > + Support for thermal sensors on Broadcom bcm2835 SoCs. small suggestion here: -If you are sending a new version fixing Nobuhiro comment, you could take the opportunity to improve the driver Kconfig help description. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
