On 01/23/2017 04:00 PM, Fabio Estevam wrote:
> On Mon, Jan 23, 2017 at 8:51 PM, Joshua Clayton
> <stillcompiling@xxxxxxxxx> wrote:
>> Add support for Altera cyclone V FPGA connected to an spi port
>> to the evi devicetree file
>>
>> Signed-off-by: Joshua Clayton <stillcompiling@xxxxxxxxx>
>> ---
>> arch/arm/boot/dts/imx6q-evi.dts | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
>> index 24fe093..a0cbb2d 100644
>> --- a/arch/arm/boot/dts/imx6q-evi.dts
>> +++ b/arch/arm/boot/dts/imx6q-evi.dts
>> @@ -82,6 +82,15 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>;
>> status = "okay";
>> +
>> + fpga_spi: cyclonespi@0 {
>> + compatible = "altr,fpga-passive-serial";
>> + spi-max-frequency = <20000000>;
>> + reg = <0>;
>> + pinctrl-0 = <&pinctrl_fpgaspi>;
>> + nconfig-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
>> + nstat-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
> Your binding doc says that 'confd-gpios ' is a required property, but
> you did not put it here.
>
> Either it is missing here or you should mention that it is optional in
> the binding doc.
You're right, Fabio.
The barebox driver from which I stole the binding had a confd and no nstat.
I've got an nstat and no confd.
One or the other is needed to know whether the bitstream was loaded.
I can add support for using the confd, but with no way to test it, I forebear.
I guess they should both be optional and a note placed that this driver
currently uses only the nstat.
Will change the doc to reflect that.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
