Hi Vinod, Thanks for the review... > > On Fri, Jan 13, 2017 at 04:28:11AM +0000, Appana Durga Kedareswara Rao > wrote: > > Hi Vinod, > > > > Thanks for the review... > > > > > > On Sat, Jan 07, 2017 at 12:15:28PM +0530, Kedareswara rao Appana wrote: > > > > Add channel idle state to ensure that dma descriptor is not > > > > submitted when VDMA engine is in progress. > > > > > > any reason why you want to make your own varible and not use the HW > > > to query as done earlier. It is not clear to me why that is removed > > > from description > > > > We need to poll for a bit in the status register to know the dma state. > > We are currently doing that in the driver hot path To avoid this using > > own variables. > > It would be worthwhile to document these, down the line people may not > remeber the motivation Sure will add comments during the variable initialization In the driver... Regards, Kedar. > > > -- > ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
