Hi Rob, On Monday 21 Nov 2016 10:48:15 Rob Herring wrote: > On Sat, Nov 19, 2016 at 05:28:01AM +0200, Laurent Pinchart wrote: > > Document properties common to several display panels in a central > > location that can be referenced by the panel device tree bindings. > > Looks good. Just one comment... > > [...] > > > +Connectivity > > +------------ > > + > > +- ports: Panels receive video data through one or multiple connections. > > While > > + the nature of those connections is specific to the panel type, the > > + connectivity is expressed in a standard fashion using ports as > > specified in > > + the device graph bindings defined in > > + Documentation/devicetree/bindings/graph.txt. > > We allow panels to either use graph binding or be a child of the display > controller. I knew that some display controllers use a phandle to the panel (see the fsl,panel and nvidia,panel properties), but I didn't know we had panels as children of display controller nodes. I don't think we should allow that for anything but DSI panels, as the DT hierarchy is based on control buses. Are you sure we have other panels instantiated through that mechanism ? > Using the graph is preferred, but in the simple cases just a child node is > sufficient. This should be described here or somewhere in this doc. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
