On Tuesday, November 22, 2016 5:22:42 PM CET zhangfei wrote: > Hi, Arnd > > On 2016年11月22日 16:45, Arnd Bergmann wrote: > > On Tuesday, November 22, 2016 3:49:16 PM CET Zhangfei Gao wrote: > >> @@ -1,8 +1,8 @@ > >> obj-y += core.o > >> -obj-y += hisilicon/ > >> obj-$(CONFIG_ARCH_STI) += sti/ > >> obj-$(CONFIG_RESET_ATH79) += reset-ath79.o > >> obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o > >> +obj-$(CONFIG_ARCH_HISI) += hisilicon/ > >> obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o > >> obj-$(CONFIG_RESET_MESON) += reset-meson.o > >> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o > > Please leave the obj-y line, otherwise the COMPILE_TEST variant won't work. > > COMPILE_TEST is added in drivers/reset/hisilicon/Kconfig > like > config COMMON_RESET_HI3660 > tristate "Hi3660 Reset Driver" > depends on ARCH_HISI || COMPILE_TEST > > The reason not using "obj-y" here is that reset.c will be compiled unconditionally. > > drivers/reset/hisilicon/Makefile > obj-y += reset.o Yes, that line has to change as well then, to only build it when one of the hardware specific drivers is enabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
