On 12/09/2013 03:32 AM, Laxman Dewangan wrote: > From: Ashwini Ghuge <aghuge@xxxxxxxxxx> > > This adds a driver for the Tegra124 pinmux, and required > parameterization data for Tegra124. > > The driver uses the common Tegra pincontrol driver utility > functions to implement the majority of the driver. > > This driver is not compatible with the earlier NVIDIA's SoCs, > hence add new compatibile as "nvidia,tegra124-pinmux". > > Originally written by Ashwini Gguhe. > Thierry: > - Cleanups in patches. > ldewangan: > - Fix some entries for groups. > - Fix MUX enums and group sequence. > +static const struct pinctrl_pin_desc tegra124_pins[] = { Still two spaces there... BTW, I said the following before for both patches; please make sure you add this to the commit description... Acked-by: Stephen Warren <swarren@xxxxxxxxxx> Even if I didn't say it before, it's certainly now, Tested-by: Stephen Warren <swarren@xxxxxxxxxx> (I also tested your patches that add the pinctrl DT entries to the Venice2 DT file. Thanks.) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html