On Wed, Nov 16, 2016 at 05:22:40PM +0530, Venkat Reddy Talla wrote: > Adding support to configure regulator POK mapping bit > to control nRST_IO and GPIO1 POK function. This leaves me none the wiser as to what this is supposed to do... > + if (chip->chip_id == MAX20024) { Please use switch statements so we can add new cases without rewriting everything. > + ret = of_property_read_u32(np, "maxim,power-ok-control", &pval); > + rpdata->power_ok = (!ret) ? pval : -1; > + Please write normal logic statements, people need to be able to read the code and understand what it does.
Attachment:
signature.asc
Description: PGP signature