On Thu, 2013-12-05 at 11:47 +0000, Mark Rutland wrote:
> On Wed, Dec 04, 2013 at 10:52:55PM +0000, dinguyen@xxxxxxxxxx wrote:
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> >
> > The SDR timing registers for the SD/MMC IP block for SOCFPGA is located
> > in the system manager. This system manager IP block is located outside of
> > the SD IP block itself. We can use the normal clock API to set the SDR
> > settings.
> >
> > Also, there is no need for "altr,dw-mshc-ciu-div" as the driver can get
> > the value of the CIU clock from the common clock API.
>
> If this property isn't necessary, please mark it as deprecated in the
> documentation.
I would deprecate it. If only there was documentation for it.
>
> [...]
>
> > + if (IS_ERR(sysmgr_clk))
> > + dev_err(host->dev, "sysmgr-sdr-mmc not available\n");
> > + else {
> > + clk_disable_unprepare(host->ciu_clk);
> > + clk_prepare_enable(sysmgr_clk);
> > + clk_prepare_enable(host->ciu_clk);
> > + }
> > return 0;
> > }
>
> This looks a little odd. Should you not return an error if you don't
> have the requisite clocks?
>
> [...]
>
> > - priv->sysreg = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> > - if (IS_ERR(priv->sysreg)) {
> > - dev_err(host->dev, "regmap for altr,sys-mgr lookup failed.\n");
> > - return PTR_ERR(priv->sysreg);
> > - }
>
> Is this property deprecated?
"altr,sys-mgr" is used in other places, so no deprecated is necessary.
>
> > -
> > - ret = of_property_read_u32(np, "altr,dw-mshc-ciu-div", &div);
> > - if (ret)
> > - dev_info(host->dev, "No dw-mshc-ciu-div specified, assuming 1");
> > - priv->ciu_div = div;
> > -
> > - ret = of_property_read_u32_array(np,
> > - "altr,dw-mshc-sdr-timing", timing, 2);
>
> Deprecated too?
Once again "altr,dw-mshc-sdr-timing" was not documented. But either way,
v4 of this patch will not be introducing any new bindings. Thanks to
Arnd's suggestion, I found a way to hook into the existing socfpga clock
driver.
Thanks alot for your review!
Dinh
>
> Thanks,
> Mark.
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
