On Mon, Aug 8, 2016 at 11:32 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Monday, August 8, 2016 11:24:02 PM CEST Linus Walleij wrote:
>> +
>> +Required subnode properties:
>> +- chipselect: <N> where N is the chipselect configured in this node
>> +- address-cells: should be <1>
>> +- size-cells: should be <1>
>> +- ranges: bool should be present
>>
>
> I think this should use a proper ranges property that translates
> the address space of the external bus into the parent bus.
>
> Just use #address-cells=<2> and make the first cell the cs number,
> as the other similar drivers do, and get rid of the chipselect
> property.
Rob Herring also wrote:
>> +Required subnode properties:
>> +- chipselect: <N> where N is the chipselect configured in this node
>
> Follow the other external buses that put the CS# in the reg property.
Also the same comment from Mark Rutland on IRC.
The following discussion is only about the CS-in-reg property problem.
The ranges issue is not fixed but that is an orthogonal thing I'm working
on.
There is a problem. Look at this cut-down example where I just have
the "qcom,xmem-recovery-cycles" set up for the CS2 chip select:
ebi2@1a100000 {
compatible = "qcom,msm8660-ebi2";
#address-cells = <1>;
#size-cells = <1>;
(...)
cs2@1b800000 {
chipselect = <2>;
#address-cells = <1>;
#size-cells = <1>;
qcom,xmem-recovery-cycles = <5>;
foo-ebi2@1b800000 {
compatible = "foo";
reg = <0x1b800000 0x100>;
(...)
};
bar-ebi2@1b800000 {
compatible = "bar";
reg = <0x1ba00000 0x100>;
(...)
};
};
};
So two devices "foo" and "bar" on the EBI2 bus, in the old
scheme.
So I need to encode the CS in the first cell of the reg for
foo-ebi2, and get rid of chipselect = <2> fine:
ebi2@1a100000 {
compatible = "qcom,msm8660-ebi2";
#address-cells = <1>;
#size-cells = <1>;
(...)
cs2@1b800000 {
#address-cells = <2>;
#size-cells = <1>;
qcom,xmem-recovery-cycles = <5>;
foo-ebi2@1b800000 {
compatible = "foo";
reg = <2 0x1b800000 0x100>;
(...)
};
bar-ebi2@1ba00000 {
compatible = "bar";
reg = <2 0x1ba00000 0x100>;
(...)
};
};
};
This is not looking good at all. First: the configuration settings for
the chipselect (i.e. all devices below it, both "foo" and "bar" are
just floating in space. When parsing the tree how should you know
what chipselect to set up the stuff on? Shall I check the child nodes
first value in the reg property and then make a majority vote on what
chipselect they apply to or what? That doesn't make sense.
So I assume doing away with the chipselect node altogether would
be prefered. But then: where do I put stuff like "qcom,xmem-recovery-cycles"
that apply to the whole chipselect, not just a single subdevice on that
chipselect? I certainly cannot encode it in the reg since it needs
to be the same for all devices and it's not about addressing.
The only thing I can reasonably come up with would be this:
ebi2@1a100000 {
compatible = "qcom,msm8660-ebi2";
#address-cells = <2>;
#size-cells = <1>;
qcom,xmem-recovery-cycles = <0>, <0>, <5>, <0>, <0>, <0>;
(...)
foo-ebi2@1b800000 {
compatible = "foo";
reg = <2 0x1b800000 0x100>;
(...)
};
bar-ebi2@1ba00000 {
compatible = "bar";
reg = <2 0x1ba00000 0x100>;
(...)
};
};
So the chip select settings are shoehorned into an array in the top
node that is then indexed to find the settings for cs0, cs1 etc.
There will be 6 such arrays for the different per-cs settings.
Is this what you want? I kind of thought the hierarchical model
was nice since each device was below its chipselect node, but
I understand that it breaks the pattern of other similar bus drivers.
So are you fine with the array solution?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
