On Thursday 18 August 2016, Linus Walleij wrote:
> On Mon, Aug 8, 2016 at 11:32 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Monday, August 8, 2016 11:24:02 PM CEST Linus Walleij wrote:
>
> So two devices "foo" and "bar" on the EBI2 bus, in the old
> scheme.
>
> So I need to encode the CS in the first cell of the reg for
> foo-ebi2, and get rid of chipselect = <2> fine:
>
> ebi2@1a100000 {
> compatible = "qcom,msm8660-ebi2";
> #address-cells = <1>;
> #size-cells = <1>;
> (...)
> cs2@1b800000 {
> #address-cells = <2>;
> #size-cells = <1>;
> qcom,xmem-recovery-cycles = <5>;
> foo-ebi2@1b800000 {
> compatible = "foo";
> reg = <2 0x1b800000 0x100>;
> (...)
> };
> bar-ebi2@1ba00000 {
> compatible = "bar";
> reg = <2 0x1ba00000 0x100>;
> (...)
> };
> };
> };
>
> This is not looking good at all. First: the configuration settings for
> the chipselect (i.e. all devices below it, both "foo" and "bar" are
> just floating in space. When parsing the tree how should you know
> what chipselect to set up the stuff on? Shall I check the child nodes
> first value in the reg property and then make a majority vote on what
> chipselect they apply to or what? That doesn't make sense.
I would have one node per chip-select and then put the devices on
that CS below it, with #address-cells=1 again.
> So I assume doing away with the chipselect node altogether would
> be prefered. But then: where do I put stuff like "qcom,xmem-recovery-cycles"
> that apply to the whole chipselect, not just a single subdevice on that
> chipselect? I certainly cannot encode it in the reg since it needs
> to be the same for all devices and it's not about addressing.
>
> The only thing I can reasonably come up with would be this:
>
> ebi2@1a100000 {
> compatible = "qcom,msm8660-ebi2";
> #address-cells = <2>;
> #size-cells = <1>;
> qcom,xmem-recovery-cycles = <0>, <0>, <5>, <0>, <0>, <0>;
No, better put the settings into one device per cs.
> So the chip select settings are shoehorned into an array in the top
> node that is then indexed to find the settings for cs0, cs1 etc.
>
> There will be 6 such arrays for the different per-cs settings.
>
> Is this what you want? I kind of thought the hierarchical model
> was nice since each device was below its chipselect node, but
> I understand that it breaks the pattern of other similar bus drivers.
Nothing wrong with having a hierarchy here, what I'm interested
in is making the addressing reflect what the hardware actually
does. With the empty "ranges", it looks like the entire 32-bit
address is getting exposed to the external bus, which is usually
not how things work: instead, each "cs" line gets raised by an I/O
operation on a particular CPU address range, and that range should
be part of the "ranges" propert of the main bus node, and the
externally visible addresses should be the translated addresses
in the child bus representation in DT.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
