Hi Meng, On Tue, 7 Jun 2016 02:40:56 +0000 Meng Yi <meng.yi@xxxxxxx> wrote: > Hi Boris, > > Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8 > > > > > > > + gpiod_set_value(sii902x->reset_gpio, 1); > > > > + > > > > + msleep(100); > > > Ouch that is some juicy number. Can we get a comment with > > > reasoning/origin of it ? > > > > As already explained to Maxime, I just don't know why this is needed, simply > > because I don't have access to the datasheet and I just based my > > implementation on another driver. > > I can add a comment stating that this was extracted from another > > implementation, but with no explanation on why this is needed. > > > > Meng, do you have any information about startup-time, or something like that? > > > > I had checked the datasheet of sii9022a, which said the Min of TRESET is 100 μs, and Max is not specified. Oh, thanks a lot. treset-min is exactly what I needed. Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html