Re: [PATCH 5/9] ARM: at91/dt: add mmc0 slot0 support to at91rm9200ek board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Linus,

On 21/11/2013 10:48, Linus Walleij wrote:
On Wed, Nov 20, 2013 at 5:14 PM, boris brezillon
<b.brezillon@xxxxxxxxxxx> wrote:
On 20/11/2013 15:59, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 13:06 Wed 28 Aug     , Boris BREZILLON wrote:
mmc0_slot0_switch-0 {
+                                               atmel,pins =
+                                                       <AT91_PIOB 22
AT91_PERIPH_GPIO (AT91_PINCTRL_OUTPUT | AT91_PINCTRL_OUTPUT_VAL(1))>;
+                                       };
nack this is a regulator the pinctrl API is not done for gpio default
value
I know this can be represented as a regulator, but looking at the datasheet,
this looks more like a switch than a regulator.
No matter whether it's a switch or a GPIO regulator it seems we
are in violent agreement that it should not be controlled by the
pin control states at least.

Start with making it a GPIO then you can figure out whether
a GPIO regulator or drivers/extcon/extcon-gpio.c should be
used.

Thanks for pointing this out. I wasn't aware of the extcon subsystem.

Actually, I think it's a little bit more tricky.

The switch connected to gpio PB22 is used to enable one device or the other:
- PB22 set to high level enables slot0 of mmc0 (connect mmc signals to the mmc
   connector)
- PB22 set to low level enables the dataflash (connect to the SPI0 signals to the
   dataflash device)

I can declare a regulator for the mmc device and attach it to the mmc (AFAIK, the mmc core will request the mmc regulator for us, and configure it accordingly).

But AFAICT (tell me if I'm wrong), there's no such things for spi devices.

The pinctrl approach has the benefit of providing a transparent way (no existing
drivers modifications) to enable one device or the other.

But if you think this is better done (or cleaner) with an extcon or a regulator device,
I'll try to find a way to do it this way.

Best Regards,

Boris


Yours,
Linus Walleij

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux