On Fri, Jun 03, 2016 at 11:40:28AM -0700, Andrew Duggan wrote: > Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt | 5 +++++ > drivers/input/rmi4/rmi_2d_sensor.c | 14 ++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt > index f2c30c8..822df11 100644 > --- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt > +++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt > @@ -37,6 +37,11 @@ Optional Properties: > disable reporing absolute position data. > - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero > command. > +- syna,dribble: Control reporting of dribble packets. Values are 0 for > + default, 1 for explicitly disable, 2 for explicitly enable. This sounds like a driver option one might choose at runtime, not a fixed hardware/integration property. Why does this belong in the DT? > +- syna,palm_detect: Control reporting of the palm detect gesture. Values > + are 0 for default, 1 for explicitly disable, 2 for > + explicitly enable. Likewise, same question here. Additionally, please use '-', not '_' in property names. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
