Hi Mark,
Thanks for reviewing.
On 06/03/2016 11:57 AM, Mark Rutland wrote:
On Fri, Jun 03, 2016 at 11:40:28AM -0700, Andrew Duggan wrote:
Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
---
.../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt | 5 +++++
drivers/input/rmi4/rmi_2d_sensor.c | 14 ++++++++++++++
2 files changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
index f2c30c8..822df11 100644
--- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
+++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
@@ -37,6 +37,11 @@ Optional Properties:
disable reporing absolute position data.
- syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
command.
+- syna,dribble: Control reporting of dribble packets. Values are 0 for
+ default, 1 for explicitly disable, 2 for explicitly enable.
This sounds like a driver option one might choose at runtime, not a
fixed hardware/integration property.
Why does this belong in the DT?
My intention is to enable or disable these properties on a platform
basis. Dribble packets could be enabled on platforms which have issues
reliably reporting data. Dribble packets report multiple finger lift
events when a finger leaves the touchpad. The default will be to disable
them, but if a platform does not reliably report data (examples we have
observed are issues with the I2C controller) then the additional finger
lift events could avoid fingers from becoming "stuck" when the host does
not receive a finger lift event.
+- syna,palm_detect: Control reporting of the palm detect gesture. Values
+ are 0 for default, 1 for explicitly disable, 2 for
+ explicitly enable.
Likewise, same question here.
Similarly, this property was added to disable this functionality on a
particular platform where it was causing interference.
Since there properties are set in firmware which is generally configured
per platform I went ahead and added them to the device tree bindings.
Additionally, please use '-', not '_' in property names.
Sorry, Rob gave me similar feedback for previous properties. But, I must
have forgotten when making this change. I can fix this if we decide to
keep these properties in devicetree.
Thanks,
Andrew
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
