On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote:
On 03/06/16 11:06, Jonathan Cameron wrote:
Code looks good, bu these more fundamental bits need sorting.
Another minor point - why do the power calculations in driver?
no hardware support for it, so why not just leave it to userspace?
Device supports the bus and shunt voltage monitoring. So even no
current. Also the warning/critical limit is for the voltage across shunt.
So should we only expose the shunt/bus voltage, no power/current?
I am thinking that user space should not know the platform and hence
shunt resistance and so exposing the current and power on bus is better
option.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html