On Fri, May 27, 2016 at 01:25:14PM +0100, Marc Zyngier wrote:
[...]
> > + } else {
> > + bus = pci_scan_root_bus(&pdev->dev, 0,
> > + &rockchip_pcie_ops, port, &res);
> > + }
> > + if (!bus)
> > + return -ENOMEM;
> > +
> > + if (!pci_has_flag(PCI_PROBE_ONLY)) {
>
> Why do you have catter for the PCI_PROBE_ONLY case? Nobody should ever
> use that for properly implemented HW.
I think that's just copy and paste and it is a useless check given
that the only way we can set that flag on ARM/ARM64 is through DT
(of_pci_check_probe_only()) and I doubt that systems probing this
driver really require a PCI_PROBE_ONLY set-up.
So, unless you can explain to us why it is really needed, please
remove the:
if (!pci_has_flag(PCI_PROBE_ONLY))
check.
Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
