Re: [PATCH v2 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 18 April 2016 at 15:44, Lars Persson <lars.persson@xxxxxxxx> wrote:
> Add a pinctrl binding to specify different pin settings for high speed
> modes and UHS modes.
>
> Signed-off-by: Lars Persson <larper@xxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> index 8babdaa..9dd9478 100644
> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> @@ -12,6 +12,10 @@ Optional properties:
>
>  - vmmc-supply: a phandle of a regulator, supplying Vcc to the card
>  - vqmmc-supply:        a phandle of a regulator, supplying VccQ to the card
> +- pinctrl-names: Must contain a "default" entry and optionally a "pins_uhs"

"state_uhs" is becoming more and more widely deployed, I suggest you
use that as well.

Moreover, I am reviewing patch 3/3 and I think some more clarification
is needed here, on whether what is required and optional. See those
comment on patch 3/3.

> +                 entry for the UHS pin configuration.
> +- pinctrl-N: One property for each name listed in pinctrl-names, see
> +             ../pinctrl/pinctrl-bindings.txt.
>
>  Additionally any standard mmc bindings from mmc.txt can be used.
>
> --
> 2.1.4
>

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux