On Mon, 11 Apr 2016, Rob Herring wrote: > On Mon, Apr 11, 2016 at 09:44:34AM +0100, Lee Jones wrote: > > On Fri, 08 Apr 2016, Wadim Egorov wrote: > > > > > Add device tree bindings documentation for rockchip's RK818 pmic. > > > > > > Signed-off-by: Wadim Egorov <w.egorov@xxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/mfd/rk808.txt | 37 +++++++++++++++++++++++-- > > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt > > > index 4ca6aab..8cceb07 100644 > > > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > > > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > > > @@ -1,7 +1,11 @@ > > > -RK808 Power Management Integrated Circuit > > > +RK8xx Power Management Integrated Circuit > > > > s/xx/XX/ > > And others say this bikeshed should be lowercase... > > I say fine as is for bindings. Uppercase for actual part letters, > lowercase for wildcards. Fair enough. NB: It should be fine to bikeshed on an RFC. I could understand your point better if we were coming to completion, or already on v5 or something. > > > +The rk8xx family current members: > > > +rk808 > > > +rk818 > > > > > > Required properties: > > > -- compatible: "rockchip,rk808" > > > +- compatible: "rockchip,rk808", "rockchip,rk818" > > > - reg: I2C slave address > > > - interrupt-parent: The parent interrupt controller. > > > - interrupts: the interrupt outputs of the controller. > > > @@ -13,6 +17,8 @@ Optional properties: > > > default output clock name > > > - rockchip,system-power-controller: Telling whether or not this pmic is controlling > > > the system power. > > > + > > > +Optional rk808 properties: > > > > When mentioning the chip by name, you should always do so using > > uppercase, as it is in the datasheet. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
