On Wednesday 02 March 2016 07:14 AM, Mark Brown wrote:
* PGP Signed by an unknown key
On Tue, Mar 01, 2016 at 06:08:13PM +0530, Laxman Dewangan wrote:
+ * @active_discharge: Enable/disable active discharge. The values are:
+ * -1: Default, 0: Disable, 1: Enable.
This isn't a good interface, it means that 0 (which is the default value
for static constrants or kzalloc()ed constraints) means to actively
discharge rather than leave the settings unchanged but our general
policy is to not touch anything unless explicitly told to do so.
Yaah, I agree.
I had other option to use 0 as default, 1 as disable and 2 as enable.
but generally for disable, we use 0 and for enable 1 and that's why I
went to -1,0,1 approach.
Will it be fine to have this as
0: Default i..e do not change.
1: disable.
2: Enable.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
