Re: [PATCH V7 1/8] mfd: add device-tree binding doc for PMIC max77620/max20024

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Thursday 11 February 2016 02:56 PM, Lee Jones wrote:
On Wed, 10 Feb 2016, Laxman Dewangan wrote:


sleep: <0/1>
             0: sleep mode disable,
             1: sleep mode enable.
Ideally yes.  This is obviously going to be used again.

However;
  - My fear is that it will get confused with the 'sleep' property in
    Documentation/devicetree/booting-without-of.txt.
  - Secondly, you would need to get Rob to Ack it.


Another thought, becasue this is just for enable/disable, why not we add property as "enable-sleep" of boolean type instead of u32 value type?

It is easy to describe the behavior with enable-sleep and enable-low-power-mode.

-enable-sleep:                  Boolean, when FPS event cleared
(set to LOW), resources get disabled at the sequencing event corresponding
                                        to its FPS configuration register.

-enable-low-power-mode: Boolean, when FPS event cleared
                                        (set to LOW), resources sets into
low power mode at the sequencing event corresponding to its FPS configuration
                                        register.

Both property can not be together.


Other approach is to club together
maxim,device-state-on-disabled-event : u32, describe the PMIC state
when FPS event cleared (set to LOW) whether it should go to sleep state or
low-power state.
1 = Device state is set to sleep 2 = Device state is set to low power mode. Absence of this property or other value will not change device state when FPS event
        cleared.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux