On Tue, 09 Feb 2016, Laxman Dewangan wrote: > > On Tuesday 09 February 2016 09:12 PM, Lee Jones wrote: > >On Sat, 30 Jan 2016, Laxman Dewangan wrote: > > > >+ Normal mode also called as active mode on which all step-down > >+ regulators, all linear regulators, GPIOs, and the 32kHz > >+ oscillator are in normal active mode. > >+ sleep mode: Regulators/GPIOs/clock can go on OFF state based on > >"can go on OFF state"? > > Regulator/GPIO has two states, enable and disable. If sleep mode is > configured for these resource and external signal triggers to sleep > then this get disabled. It's the English that I'm unhappy with. "can go on OFF state" doesn't sound right. > >>+ source gets the control signal for ON and OFF. > >>+ Power on slot: Slot number on which resource is ON once FPS source > >>+ get ON signal. > >Can you find another way of explaining this please? > > Hmm.. > Does it look fine: > There is 8 slots for each FPS on which resource can get enabled. > This property provides the slot number on which resource gets > enabled after FPS sequence started. It's a bit better, yes. Although it's still a little difficult to read. In fact, I can't even recommend a suitable alternative, since I still do not understand exactly what it is you're trying to say. > >+ > >+-maxim,enable-sleep: Boolean, enable sleep state of PMIC > >We already have bindings for sleeping. Please use a generic one. > > Which property? Saw sleep property with vendor prefix. I guess there are too many '.*sleep.*' properties now, each with slightly different syntax and meaning. The situation is exacerbated by one of the key examples is using the property with cells expected i.e. non-bool. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
