Hi > >> Define the generic R8A7794 part of the sound device node. > >> This sound device is a complex one and comprises the Audio Clock Generator > >> (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit] > >> (SSI[U]), and Audio DMAC-Peripheral-Peripheral. > >> It is up to the board file to enable the device. > >> > >> This patch is based on the R8A7791 sound work by Kuninori Morimoto. > >> > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > >> > >> --- (snip) > > My reading of the documentation is that src0, 7, 8 and 9 are not > > present on the r8a7794. I am referring to Figure 38.1b or r1.02 of > > the R-Car Gen2 User's Manual. > > Indeed, thank you for the timely comment (I'm working on the series > respin)! However, table 7A.12 still lists the SRC0/7/8/9 clocks for > R8A7794, table 11.1 still lists SRC0/7/8/9 interrupts for R8A7794, and > table 43.4 still lists SRC0/7/8/9 MID+RID for R8A7794 -- go figure... Oops, current rsnd driver is assuming that DT has all channels. This means it doesn't check src number itself. Can you add src0, 7, 8, 9 with "non exist" comment ? Otherwise, we need to modify driver, but I'm not sure how this assumption is deep. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
