Alexander Aring <alex.aring@xxxxxxxxx> writes: > Hi, > > On Tue, Nov 24, 2015 at 09:44:59PM +0100, Ulf Hansson wrote: >> [...] >> >> > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig >> > index 8c53c55..20479d7 100644 >> > --- a/arch/arm/mach-bcm/Kconfig >> > +++ b/arch/arm/mach-bcm/Kconfig >> > @@ -134,6 +134,16 @@ config ARCH_BCM2835 >> > This enables support for the Broadcom BCM2835 SoC. This SoC is >> > used in the Raspberry Pi and Roku 2 devices. >> > >> > +config RASPBERRYPI_POWER >> >> You don't need a new Kconfig option I think. If you fold in the below >> "select" under ARCH_BCM2835, that should work as well, right? >> >> select PM_GENERIC_DOMAINS if (RASPBERRYPI_FIRMWARE && PM && OF) >> > > I think this depends on what the maintainers like to have here. > > The raspberrypi firmware isn't BCM2835 specific, when some SoC which is > BCM2835 and enabled the RASPBERRYPI_FIRMWARE (for what reason ever) it will > enable also the power domain driver for the RPi. > > When some BCM2835 enable it, then it will do nothing because the > devicetree entries should not match then. As far as I'm concerned, using the firmware is a stopgap to get other drivers working, until we can get a native power domain driver written. I think it makes sense for this code to be under its own menu entry, so it can be flipped back off when we get the real thing in place.
Attachment:
signature.asc
Description: PGP signature
