On Fri, Oct 25, 2013 at 03:48:41PM -0700, Anton Vorontsov wrote: > On Mon, Oct 14, 2013 at 12:40:26PM -0600, Stephen Warren wrote: > > >>> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt > > >> > > >>> +Optional properties : > > >> > > >>> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter > > >>> + presence. > > >> > > >> Is that actually a property of the BQ24735 chip itself (i.e. is it an > > >> output signal from the chip), or part of the board/system? > > > > > > The gpio itself is actually what the IRQ line is tied to from the > > > bq24735 -> tegra (in this case). In other words this is a Host GPIO that > > > is configured as an input and connected to the bq24735. > > > > Ok, so this is the ACOK output pin? In that case, it's fine. It might be > > worth mentioning that explicitly though. > > I added the comment to the documentation and applied the patch with a > "Thanks-to: Stephen Warren <swarren@xxxxxxxxxxxxx>" tag. :) Oh, and as well as Thanks-to: Thierry Reding <thierry.reding@xxxxxxxxx> (People seem to review drivers, but do not give their Reviewed-by tags, so the thanks tag is the best thing I can legally do in such a case.) Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html