On 10/14/2013 12:26 PM, Rhyland Klein wrote: > On 10/14/2013 2:21 PM, Stephen Warren wrote: >> On 10/11/2013 03:15 PM, Rhyland Klein wrote: >>> From: Darbha Sriharsha <dsriharsha@xxxxxxxxxx> >>> >>> Adds support for the bq24735 charger chipset. The bq24735 is a >>> high-efficiency, synchronous battery charger. >>> >>> It allows control of the charging current, input current, and the charger >>> voltage DAC's through SMBus. >> >> Please CC the DT bindings maintainers on patches that add DT bindings. > > Oops, sorry, will do in the future. > >> >>> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt >> >>> +Optional properties : >> >>> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter >>> + presence. >> >> Is that actually a property of the BQ24735 chip itself (i.e. is it an >> output signal from the chip), or part of the board/system? > > The gpio itself is actually what the IRQ line is tied to from the > bq24735 -> tegra (in this case). In other words this is a Host GPIO that > is configured as an input and connected to the bq24735. Ok, so this is the ACOK output pin? In that case, it's fine. It might be worth mentioning that explicitly though. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html