On Wed, 2013-09-11 at 20:31 -0500, Tang Yuantian-B29983 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: 2013年9月12日 星期四 9:10 > > To: Tang Yuantian-B29983 > > Cc: galak@xxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; Li Yang-Leo-R58472 > > Subject: Re: [PATCH v4] powerpc/mpc85xx: Update the clock device tree > > nodes > > > > This description of "reg" is overly specific (assumes how the parent > > node's ranges are set up), incomplete (there's a size as well as the > > offset), and does not apply to the clockgen node itself (you probably > > shouldn't lump them together like this). > > > Do you mean I should explain the REG of clockgen and its child node respectively? > > > > +- clocks : shall be the input parent clock phandle for the clock. > > > > Not required on the clockgen node > > > Required by child node of clockgen. My point is that you're lumping several different types of nodes together with one binding, when some parts of the binding are not applicable to the clockgen node. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
