On Tue, Aug 27, 2013 at 9:42 AM, Nicolas Ferre <nicolas.ferre@xxxxxxxxx> wrote: > On 27/08/2013 08:16, boris brezillon : > Deglitch and > Debounce filters are different features in at91 (even if they pursuit the > same goal). So I do prefer to let the user choose which feature is preferred > for his application and add a different flag. Electrically speaking debounce and deglitch are totally different things. Debounce is for, well debouncing. To even out the effect of pressing a button which due to mechanical characteristics create a sharp series of spikes like that: _ _ _| |_| |_ I highly suspect that "deglitch" is either: - A one-spike version of the above (in which case a custom config may be warranted) or - What we usually call schmitt-trigger, i.e. handling of analog swing-in. Can you describe exactly what the two features do, in electrical terms? > The question is: how much this "generic" pinconf is... well... generic! And > it is not a answer I can give. The generic configs are defined from electrical use-cases that appear in practice and also have the character of appearing in similar implementations in I/O cells of several vendors, to the point that from a software perspective they are identical. > On the other hand, if the "generic" is not going to overcome the native > pinctrl, I do not feel like switching to this at the cost of changing the > whole dtsi/dts entries that we already have. The question we ask in this case is whether the electrical construction is so fantastically unique and ingenious that no other ASIC pad implementer sitting in his chamber working on I/O cells would possibly ever come up with the same concept. If that is true, then it warrants its own, custom binding. If you ask some other randong cell implementer whether this is something they would do, and they say "yeah I have that in the next version of my cell library" then it is generic, because we will see the same thing in other systems as time moves on. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
