On 08/26/2013 11:01 AM, boris brezillon wrote: > Hello Stephen, > > On 26/08/2013 18:50, Stephen Warren wrote: >> On 08/24/2013 03:35 PM, Boris BREZILLON wrote: >>> Add a new parameter to support deglitch filter configuration. >>> A deglitch filter works like a debounce filter but with a smaller >>> delay (nanoseconds). >> Why not use the existing debounce property, just with a small delay >> specified. It seems like that's exactly what the property is for? > That's one of the question I asked in my cover letter :-) > > Indeed the at91 deglitch filter delay is not configurable and is statically > assigned to half a master clk cycle (if master clk = 133MHz -> 8 ns). > The debounce property argument is currently expressed in usecs. > > This will result in always selecting the debounce filter (which is also > available on at91 SoCs) over the deglitch filter. > > Could we add a flag in the deglitch argument to specify the delay unit > (nsecs or usecs) ? If the value is hard-coded in HW, why not use non-zero (or 1) to enable and zero to disable? (this kind of thing is why I'm not convinced that generic pinconf works so well... What if we need psecs in the future?) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
