On Tue, Mar 02, 2021 at 02:58:19PM -0500, Ryan Long wrote:
> Fixed "Unchecked return value" error, by adding "(void)" in front of the
> function call.
>
> When Coverity Scan was ran on some of your code, a "Unchecked return value"
> error was found at line 352 in fdt_rw.c. For similar errors that we received
> for RTEMS, we created a macro that will assert the value returned and "use" the
> return value with (void).
>
> Signed-off-by: Ryan Long <ryan.long@xxxxxxxxxxx>
It's weird that the Coverity Scan on dtc upstream didn't pick this
up. I thought maybe it did at some point and I just marked it as a
false positive, but I looked through and I couldn't seem to find it at
all (though the Coverity UI is pretty confusing, so maybe I just
missed it).
I've taken a slightly different approach to squashing this upstream,
so I haven't applied this as is.
> ---
> cpukit/dtc/libfdt/fdt_rw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c
> index 1385425..cdae5dd 100644
> --- a/cpukit/dtc/libfdt/fdt_rw.c
> +++ b/cpukit/dtc/libfdt/fdt_rw.c
> @@ -348,7 +348,7 @@ int fdt_add_subnode_namelen(void *fdt, int parentoffset,
> return offset;
>
> /* Try to place the new node after the parent's properties */
> - fdt_next_tag(fdt, parentoffset, &nextoffset); /* skip the BEGIN_NODE */
> + (void) fdt_next_tag(fdt, parentoffset, &nextoffset); /* skip the BEGIN_NODE */
> do {
> offset = nextoffset;
> tag = fdt_next_tag(fdt, offset, &nextoffset);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
