Re: [PATCH] Unchecked return value error in fdt_rw.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Mar 01, 2021 at 08:29:49PM -0600, Rob Herring wrote:
> On Mon, Mar 1, 2021 at 4:27 PM Ryan Long <thisisryanlong@xxxxxxxxx> wrote:
> >
> > Hi,
> >
> > I filed an issue on github, but I was told it'd be good to send this to
> > the mailing list as well.
> >
> > RTEMS (RTEMS.org) is a free single process, multi-threaded real-time operating
> > system with a long history. Your dtc toolchain has been incorporated into
> > RTEMS. The RTEMS Project is a member of the Coverity Scan program and it
> > flagged an issue with /dtc/libfdt/fdt_rw.c. In trying to be good citizens of
> > the wider open source community, the project wants these issues to be reported
> > to the upstream owner along with a fix or suggestions. This is one of those
> > reports.
> >
> > When Coverity Scan was ran on some of your code, a "Unchecked return value"
> > error was found at line 352 in fdt_rw.c. For similar errors that we received
> > for RTEMS, we created a macro that will assert the value returned and "use" the
> > return value like so.
> 
> Humm, I think Coverity scans run on the Linux kernel too, but I've
> never seen any reports on the kernel's copy. Just wondering why...

It runs on dtc upstream as well.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux