On Tue, Mar 29, 2022 at 8:18 PM Kaleb Keithley <kkeithle@xxxxxxxxxx> wrote: > > > On Tue, Mar 29, 2022 at 7:59 PM Gregory Farnum <gfarnum@xxxxxxxxxx> wrote: >> >> >> >> install-deps.sh should handle grabbing any relevant packages. >> > > Nope. Bad assumption. > > I'll be happy to walk you through building packages for RHEL, Fedora, and CentOS SIGs some time. > > Brew, Koji, and CBS all run builds in mock. Dependencies are preloaded and installed before rpmbuild runs. mock has networking disabled by default, so you quite simply can't do things like install other rpms, download outside sources, or do a git submodule init. > > I have some experience with pbuilder on Debian and Ubuntu too, but I don't know if it disables networking like mock does, although I suspect it may. > > -- > > Kaleb since this is a discussion about our default values for WITH_SYSTEM_ cmake variables, i think it's best to separate out packaging concerns - we assume that distros are customizing these WITH_SYSTEM_ variables to match what's available, as we do in-tree with ceph.spec.in and debian/rules these cmake defaults are most important for ceph developers doing their local builds. and here, we do expect that install-deps.sh will install any system packages that are available on the user's distro from the perspective of a ceph developer trying to get the fastest local builds, i agree that it would be nice for some of these variables to default to ON instead of tuning them manually but from the perspective of maintaining an open source project, i also see a value in making sure that our default cmake configuration 'just works'. ceph is a big project with a complicated build system. by minimizing barriers to entry, we encourage more participation in the project _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
