On 11/19/2013 09:23 AM, Eric Dumazet wrote: > On Tue, 2013-11-19 at 12:35 +0100, Daniel Borkmann wrote: >> On 11/19/2013 05:00 AM, Eric Dumazet wrote: >>> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote: >>> >>>> But sctp is not tcp ;) >>>> >>>> sctp_copy_sock() is doing some clever/partial copy of the socket, so >>>> please fix it ;) >>>> >>>> No idea why it's not doing the normal copy of the socket. >>> >>> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE >>> is broken for SCTP. >> >> Yep, indeed. Looking into it ... > > It might be the time to finally use inet_csk_clone_lock() in SCTP. > > I can see sk_clone_lock() since SCTP doesn't use icsk sockets. Need to study the code a bit. -vlad -- To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
