On Thu, Feb 27, 2014 at 12:25 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > Hi Rashika, > > On 26 February 2014 22:08, Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote: >> Mark function as static in cpufreq.c because it is not >> used outside this file. >> >> This eliminates the following warning in cpufreq.c: >> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for 'show_boost' [-Wmissing-prototypes] > > Can you please elaborate how this warning is related to > the non-static definition of this function? -Wmissing-prototypes warns when a non-static function is defined before a corresponding prototype (usually inside an included header file) is declared. In such a case, it is impossible to reference the non-static function from another file, and therefore the function should be marked static (usually). Hope that makes sense! -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
