On Fri, Jul 24, 2009 at 03:25:01PM +0200, Thomas Renninger wrote:
> Hi,
>
> while trying on the global ondemand sysfs and machine wide
> governor switching I run into two bugs introduced lately.
>
> This patch series fixes the two bugs.
> Also the set_speed changes should be rather harmless.
>
> The last three patches are about the global sysfs directory:
> /sys/devices/system/cpu/cpufreq
> - One patch for creating it
> - One patch for ondemand using it
> - One patch for machine wide governor switching
> -> different governors per core will not be allowed anymore then.
>
> Still all current sysfs files are usable the same way
> (beside that chaning a governor of a cpu will change all and a slight
> modification of set_speed file -> will now be created when the userspace
> governor gets activated and will be removed when switching to another
> governor).
>
> The last patch is the most intrusive one, especially store_scaling_governor().
> I did a parallel online/offlining, governor switching and showing stress test
> which identified the first two bugs. It even found a NULL pointer in
> 2.6.27 when I wanted to find out whether this works at all.
> It now seem to work, beside a little, IMO not sever side effect which
> is described in the patch itself.
>
> Further cleanups possible:
> - Provide a global (not per core) governor start/exit entry func
> - Rip out all the deprecated things in a while
> - I forgot the conservative governor..., no time right now, I will
> send something if this gets accepted
>
> Comments?
> Can this make it into next?
Applied (except for 1/6 as noted in other mail), but I had to fix up
a bunch of trivial stuff..
ERROR: space required after that ',' (ctx:VxV)
#1751: FILE: drivers/cpufreq/cpufreq.c:529:
+ int i,j;
^
ERROR: space required before the open parenthesis '('
#1975: FILE: drivers/cpufreq/cpufreq.c:822:
+ if(!strncmp(attr->name, "scaling_governor", 16)) {
WARNING: printk() should include KERN_ facility level
#1976: FILE: drivers/cpufreq/cpufreq.c:823:
+ printk("Scaling gov found\n");
ERROR: space required before the open parenthesis '('
#1980: FILE: drivers/cpufreq/cpufreq.c:827:
+ if(!scal_gov) {
ERROR: space required before the open parenthesis '('
#1981: FILE: drivers/cpufreq/cpufreq.c:828:
+ if(lock_policy_rwsem_write(policy->cpu) < 0)
ERROR: space required before the open parenthesis '('
#1991: FILE: drivers/cpufreq/cpufreq.c:837:
+ if(!scal_gov)
WARNING: line over 80 characters
#2051: FILE: drivers/cpufreq/cpufreq.c:2090:
+ WARN_ON(sysfs_create_file(cpufreq_global_kobject, &scaling_driver.attr));
total: 5 errors, 2 warnings, 1264 lines checked
Please remember to run scripts/checkpatch.pl before submitting.
Thanks,
Dave
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
