On Fri, Jul 24, 2009 at 10:58:35AM -0400, Mathieu Desnoyers wrote: > > > @@ -806,8 +807,6 @@ int cpufreq_add_dev_policy(unsigned int cpu, > > struct cpufreq_policy *policy, > > > ret = sysfs_create_link(&sys_dev->kobj, > > > &managed_policy->kobj, > > > "cpufreq"); > > > - if (!ret) > > > - cpufreq_cpu_put(managed_policy); > > > /* > > > * Success. We only needed to be added to the mask. > > > * Call driver->exit() because only the cpu parent of > > Hmm, only the "!" must get reverted which was my initial fix, but I > > wanted to do better :(. > > So this hunk is also wrong it must be: > > - if (!ret) > > + if (ret) > > Ah, yes, this logic inversion is indeed a problem. Can you resubmit with > just this fix ? > > Thanks, > > Mathieu Yep, please do. I just applied everything else that I had backlogged to the fixes/next branches of cpufreq.git If anything else seems to be missing, it fell through the cracks, so please resend. Dave -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
